base-ui icon indicating copy to clipboard operation
base-ui copied to clipboard

Published 20 hours ago • verified publisher icon mui

[accordion] Implement Accordion

Open michaldudak opened this issue 2 years ago • 4 comments

This is the place to gather ideas, measure interest and discuss the API and implementation details of the accordion component and hook.

See https://github.com/mui/base-ui/issues/10 for the umbrella issue to track progress on Base UI and https://github.com/mui/material-ui/issues/6218 for the problem this project solve.

michaldudak avatar Jul 19 '23 12:07 michaldudak

Material UI id API feels so outdated (e.g. id={summary.props['aria-controls']}) now that we can use the context and useId https://mui.com/material-ui/react-accordion/#basic-accordion

Screenshot 2023-08-15 at 00 52 48

oliviertassinari avatar Aug 14 '23 22:08 oliviertassinari

To consider what we should do with the arrow key navigation https://www.w3.org/WAI/ARIA/apg/patterns/accordion/#keyboardinteraction. I don't know if we want this, I guess, why not?

oliviertassinari avatar Aug 14 '23 23:08 oliviertassinari

an idea for the base-ui accordion component is to use the details and summary HTML elements for the component so that the accordion would still work for users who have javascript turned off. i feel like semantically it might also make more sense since its functionality is similar to the accordion component

logonoff avatar Jan 11 '24 07:01 logonoff

Related issue to take into consideration: https://github.com/mui/material-ui/issues/36297

michaldudak avatar Jan 19 '24 13:01 michaldudak