base-ui
base-ui copied to clipboard
[code-infra] Normalize pkg in codebase
Seeing https://github.com/mui/base-ui/pull/2148#issuecomment-2994386002 made me want to have all the codebase use the same configuration.
- https://github.com/mui/mui-x/pull/18487
- https://github.com/mui/material-ui/pull/46404
- https://github.com/mui/base-ui/pull/2149
On either the comment should be here or not, the argument that was raised so far is that we should optimize for the DX, which I believe yields the best DX https://github.com/mui/base-ui/pull/1865#discussion_r2076085937
Bundle size report
@base-ui-components/react parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/accordion parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/alert-dialog parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/avatar parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/checkbox parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/checkbox-group parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/collapsible parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/context-menu parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/dialog parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/direction-provider parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/field parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/fieldset parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/form parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/input parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/menu parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/menubar parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/merge-props parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/meter parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/navigation-menu parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/number-field parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/popover parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/preview-card parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/progress parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/radio parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/radio-group parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/scroll-area parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/select parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/separator parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/slider parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/switch parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/tabs parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toast parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toggle parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toggle-group parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toolbar parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/tooltip parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/unstable-no-ssr parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/unstable-use-media-query parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/use-render parsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/utils parsed: 0B(0.00%) gzip: 0B(0.00%)
Generated by :no_entry_sign: dangerJS against 2358225eb92381e2851ed67ba45c3082dd951788
Deploy Preview for base-ui ready!
| Name | Link |
|---|---|
| Latest commit | 2358225eb92381e2851ed67ba45c3082dd951788 |
| Latest deploy log | https://app.netlify.com/projects/base-ui/deploys/68585977b0aeee00096e50f2 |
| Deploy Preview | https://deploy-preview-2149--base-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
On comments: both @atomiks and I agree that having these comments is useful. As we're the maintainers, we're the ones who might feel the burden of too many notifications, but we still think it's worth it. It'll be especially useful with https://github.com/mui/base-ui/pull/1885. Another solution that could be a good compromise is to have one comment with all the generated content: bundle size, deploy preview and canary packages. Can we please leave the current state until we have the target solution?
Seeing https://github.com/mui/base-ui/pull/2148#issuecomment-2994386002 made me want to have all the codebase use the same configuration.
What does it have to do with configuration?
Implemented in #2258