base-ui icon indicating copy to clipboard operation
base-ui copied to clipboard

[code-infra] Normalize pkg in codebase

Open oliviertassinari opened this issue 5 months ago • 3 comments

Seeing https://github.com/mui/base-ui/pull/2148#issuecomment-2994386002 made me want to have all the codebase use the same configuration.

  • https://github.com/mui/mui-x/pull/18487
  • https://github.com/mui/material-ui/pull/46404
  • https://github.com/mui/base-ui/pull/2149

On either the comment should be here or not, the argument that was raised so far is that we should optimize for the DX, which I believe yields the best DX https://github.com/mui/base-ui/pull/1865#discussion_r2076085937

oliviertassinari avatar Jun 22 '25 19:06 oliviertassinari

Bundle size report

@base-ui-components/reactparsed: 0B(0.00%) gzip: 0B(0.00%)

Show details for 39 more bundles

@base-ui-components/react/accordionparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/alert-dialogparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/avatarparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/checkboxparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/checkbox-groupparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/collapsibleparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/context-menuparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/dialogparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/direction-providerparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/fieldparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/fieldsetparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/formparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/inputparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/menuparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/menubarparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/merge-propsparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/meterparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/navigation-menuparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/number-fieldparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/popoverparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/preview-cardparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/progressparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/radioparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/radio-groupparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/scroll-areaparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/selectparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/separatorparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/sliderparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/switchparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/tabsparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toastparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toggleparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toggle-groupparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/toolbarparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/tooltipparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/unstable-no-ssrparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/unstable-use-media-queryparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/use-renderparsed: 0B(0.00%) gzip: 0B(0.00%) @base-ui-components/react/utilsparsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 2358225eb92381e2851ed67ba45c3082dd951788

mui-bot avatar Jun 22 '25 19:06 mui-bot

Deploy Preview for base-ui ready!

Name Link
Latest commit 2358225eb92381e2851ed67ba45c3082dd951788
Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68585977b0aeee00096e50f2
Deploy Preview https://deploy-preview-2149--base-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 22 '25 19:06 netlify[bot]

On comments: both @atomiks and I agree that having these comments is useful. As we're the maintainers, we're the ones who might feel the burden of too many notifications, but we still think it's worth it. It'll be especially useful with https://github.com/mui/base-ui/pull/1885. Another solution that could be a good compromise is to have one comment with all the generated content: bundle size, deploy preview and canary packages. Can we please leave the current state until we have the target solution?

Seeing https://github.com/mui/base-ui/pull/2148#issuecomment-2994386002 made me want to have all the codebase use the same configuration.

What does it have to do with configuration?

michaldudak avatar Jun 23 '25 10:06 michaldudak

Implemented in #2258

michaldudak avatar Jul 30 '25 13:07 michaldudak