base-ui icon indicating copy to clipboard operation
base-ui copied to clipboard

[Select][Menu] Better handle dynamic and non-string items

Open atomiks opened this issue 6 months ago • 2 comments

  • Select: Fixes #1853 to ensure non-string values don't warn, clears styles and scroll arrows state when the item list size changes
  • Select: Fixes #1922 to ensure the selectedItemTextRef.current is set when the previous text element gets disconnected, fixing the positioning
  • Select + Menu: Fixes focus restoration (add restoreFocus prop) to ensure keyboard navigation works when item is removed while menu is open
  • Select: Fixes error due to scrollArrow visibility state changing state of parent component in render by moving it locally

atomiks avatar May 05 '25 01:05 atomiks

Deploy Preview for base-ui ready!

Name Link
Latest commit 1f4f04e2488df849b5db22367bd9c4495bd1fc31
Latest deploy log https://app.netlify.com/projects/base-ui/deploys/682e9592de0685000860ed6a
Deploy Preview https://deploy-preview-1861--base-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 05 '25 01:05 netlify[bot]

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@1861

commit: 1f4f04e

pkg-pr-new[bot] avatar May 07 '25 09:05 pkg-pr-new[bot]