basecrack icon indicating copy to clipboard operation
basecrack copied to clipboard

A suggestion

Open vu1Art1st opened this issue 2 years ago • 2 comments

In file base_chain.py line 88, I suggest to change the code base64.b16decode(encoded_base, casefold=False).decode('utf-8', 'replace') to base64.b16decode(encoded_base.upper(), casefold=False).decode('utf-8', 'replace')

vu1Art1st avatar Oct 30 '23 06:10 vu1Art1st

Just ran into this issue and I agree, but then why not casefold=True? The docs say "For security purposes, the default is False" for casefold. I don't see why there would be any security concern of accepting lower-case input for this project, correct me if I'm wrong.

berwil-1 avatar Sep 05 '24 13:09 berwil-1

Just ran into this issue and I agree, but then why not casefold=True? The docs say "For security purposes, the default is False" for casefold. I don't see why there would be any security concern of accepting lower-case input for this project, correct me if I'm wrong.

Sry, I didn't view the whole code.This suggestion just try to resolve an error when decoding lower case base32, for this i just add ".upper()"

vu1Art1st avatar Sep 09 '24 11:09 vu1Art1st