pythonBits
pythonBits copied to clipboard
mueslo
Better scene detection
I'm sorry, but I really don't see the attack vector. We don't pickle arbitrary stuff from the API, we pickle requests.Response objects that we already trust.
If the attacker controls the API, they would have to find a vulnerability in requests.Response. And if they can do that, it doesn't matter if malicious objects are pickled or not.
@plotski you as the committer can still hide almost arbitrary code in there, which will get executed if you run tests. It's like a proprietary software blob. This is what I disagree with.
Oh, right. Good point. I didn't think of that.
I'll work something out without pickles.
API responses are now stored as plain text files. Are we good on the other points you raised?
os.path.splitext(os.path.basename("The.Title.2000.x265-GRP"))[0] ('The.Title.2000', '.x265-GRP')
A scene file in a directory with the wrong folder name yields "scene: False". This is another regression, while it would be possible to detect that this is basically equivalent to a renamed scene release, previously it at least queried the user.