Christian Muehlhaeuser

Results 452 comments of Christian Muehlhaeuser

Hey @mattn! Nice seeing you over here! Your contribution looks great, but I'm a bit puzzled about the `go fmt` changes. I can't reproduce that output locally, neither with `go...

> [golang/go#51082](https://github.com/golang/go/issues/51082) > > gofmt is changed Understood! This seems to be a pending change for 1.19, tho? Can't reproduce it with 1.18.3 for what it's worth. I think we...

> I can squash this changes. Do you want? Thanks, but no need to, can do that here just fine!

We're working on allowing users to specify custom input & output handles, which may superseed this change. You're making valid points however, and I wonder if there's any disadvantage to...

The sleep might be problematic, as there's no guarantee how long node will take to finish/release `stdin`.

I need to check if that's really possible. The OSC queries are meant to be transferred via `stdout`, but we can certainly see how terminals react to them being written...

> Maybe use or adapt this Sindre’s nodejs port: https://github.com/jwalton/go-supportscolor `termenv` (and hence `lipgloss`) is already doing that (and more) internally, and that operation doesn't depend on stdout vs stderr....

@rubiojr Just a quick heads up: we love all your PRs! `testify` as a dependency for the tests is absolutely fine. I'll fix the goreleaser workflow failing for PRs asap.

You should already be able to do this without any changes to the image, by using the `--user` flag or slightly adjusting your `docker-compose.yml`: ```yml services: charm: image: charmcli/charm:latest user:...