Christian Muehlhaeuser
Christian Muehlhaeuser
Here's one thing I dislike about my own change: this doesn't protect the `value` member of the `Style`. This is typically not a problem, because we operate on a copy...
This looks pretty cool, even though it does complicate the common code paths a bit. I guess we could try and separate a bit of the nested rendering code.
Similar to our `table` implementation, I think it would be desirable to support custom data models.
Please do fix this upstream if you found any issues. At first glance I don't see a difference however?
Yeah, definitely willing to accept PRs there, so we don't end up copying similar code all over the place.
> I will provide a repository shortly showcasing the problem and why this pull request resolves the problem. Cool, a few test cases might be nice here.
Nice work on the layout management! I guess I'll need a bit more time to digest all of this and play with it, before I can provide some proper feedback....
This is lipgloss querying the terminal for its color support. It should only ever happen once on startup, and you're obviously not supposed to see it. How do you reproduce...
@benleb Can you point me to the place in code where you print/render to stdout? Is it possible that this is happening concurrently with another print call?
You can write your own item delegate that picks a different style for each item.