muesli icon indicating copy to clipboard operation
muesli copied to clipboard

Mails not sent to users with only preferences given

Open SinForest opened this issue 8 years ago • 2 comments

Mails sent to the whole course seem not to be sent to users who only gave preferences and are not assigned to a group yet.

(Not really tested, only an assumption)

SinForest avatar Oct 18 '16 12:10 SinForest

I just figured out People really using the github issues of my former second remote on muesli-development. Sorry I had no notifications turned on for this project. But now back to topic:

The relevant code can be found here: muesli/web/viewsLecture.py#L394-L415

In line 400 you can see that only the students which are assigned to the lecture (assigned means in this context that the joined or got joined to a tutorial). What is better in your opinion? To add this feature in addition or to send this mail to not assigned, but preferences given students, too?

joker234 avatar Jul 26 '17 20:07 joker234

Right now I don't see any use cases where you would want to send an email to all assigned students and explicitly not to people who are not assigned to any tutorials. But since there might be some I don't see it might be the better idea to make this optional somehow.

SinForest avatar Jul 26 '17 20:07 SinForest