Scott Wilson

Results 109 comments of Scott Wilson

> So, I wonder whether it is better to keep Splay as it is, > and add a Splay variant class with the new behavior? I agree it's difficult to...

Hmm Travis failed on OSX with: ``` Fetching submodule external_libraries/nova-tt 5754fatal: remote error: upload-pack: not our ref 4e307364528bd36b80fa61ccf2d3b60916dbba51 5755The command "git fetch --tags" failed and exited with 1 during ....

Hmm looks like similar issues in other PRs right now.

> A unit test for this raises a sync issue: `Document.new` synchronously adds to the allDocuments collection -- so there's no way here to avoid a hardcoded wait as far...

> So we'd be stuck with a timed pause, I think. Okay, so I'm unclear. Should I write a test with a wait (for how long?) or just save it...

thanks James!

> travis's push job is failing because this branch diverged before #4691. i'm fine ignoring it, but just noting that if you want to see a green check there you'll...

I've not added the test here for reasons discussed above. Would make sense perhaps to update #4582 and then add it there? I can do this.

Okay I think this otherwise ready? All tests passing.

> EDIT -- very confused what you mean by "for reasons discussed above". why not just add the test here and then resolve merge conflicts when merging 3.10 into develop?...