Zach Mueller
Zach Mueller
For newly added code I agree we can just stick with `|`, the import will help fix anyone on a lower python version that doesn't support it "natively" yet. And...
@akx do you want to go ahead and include `from __typing__ import annotations` + the ruff rule for it? :)
Sure, we can do that
Although, since we have the type annotations here being used, let's just add it here as our CI runs python 3.8 iirc so it'll just immediately break(?) (maybe not since...
Perhaps not...!
But for downstream libraries that rely on accelerate and will want to integrate with the HfArgumentParser, this could matter.
@nbertagnolli nice idea! Feel free to open a draft PR if you'd like adding it to the callbacks :)
@yuane4 can you please share your entire script?
@richardodliu do `pip install -e .[quality]; make fixup` and this should make the code quality tests pass!