LocalAI
LocalAI copied to clipboard
feat: migrate to echo
Description
This PR migrates to echo. One of the main reason is the lack of support of detecting properly client cancellation https://github.com/valyala/fasthttp/issues/468#issuecomment-439665014, which would have the unwanted effect of booking resources for AI inferencing even if clients disconnect.
I've tried several workarounds in https://github.com/mudler/LocalAI/pull/7187 , but none of these was reliable ( had to revert in https://github.com/mudler/LocalAI/pull/7266 ). Finally, I've came to the conclusion that the effort involved in maintaining go-fiber (which is based over fasthttp) is higher overall for the little gain that we would have (the real computation is offloaded, so we don't perform high-intensive tasks in the golang layer) by using it.
Notes for Reviewers
Signed commits
- [ ] Yes, I signed my commits.
Deploy Preview for localai ready!
| Name | Link |
|---|---|
| Latest commit | 4c7c4b00e087f4654a554e06b9f1fe911954539a |
| Latest deploy log | https://app.netlify.com/projects/localai/deploys/691797af8bbede000866d497 |
| Deploy Preview | https://deploy-preview-7270--localai.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.