MuditaOS
MuditaOS copied to clipboard
[EGD-7257] Czech localization (by @lukascalda)
This is resubmission of Czech localization from PR #2019 which was prematurely closed before it was merged.
Issue #1990 can be closed if this PR is merged.
I've edited your comment - it has wrong issue number :)
@lukascalda :)
Hi guys, I got lost a bit here. Should I take some actions?
Hi guys, I got lost a bit here. Should I take some actions?
@lukascalda, you're here!
There are actually several of new strings that need translating. I'm not sure if they existed before but there are "profile" files that also need adding. The profiles seem to be for key entry and a very short.
I've added a script (missing_strings.sh) to check what isn't translated. If you want to avoid all the confusing git rebase stuff then you can just fork my repo, edit the files, do a PR to my repo, and I'll just update the files here.
Do note that I've normalized the file names to "Chesky" to match the other normalized translation file names. git doesn't seem to handle unicode file names very well.
Okay, I get it. Made some mistakes before. Gotta learn github better. I have made some slight tweaks to my translation, still some lines not translated (190-228) - app related, device should be ready. It was not merged before, because there was missing review. So what now? New pull request?
@lukascalda, The reason your PR wasn't merged due to multiple issues:
- commits need to be collapsed into a single commit
- commit message was non-conformant
- needed two reviews
- need to rebase it so it can be merged
- do not close the PR
You can fix all these issues, make a PR and keep it up to date until it gets merged.
Alternatively, you can...
- clone my repo (
git clone [email protected]:GravisZro/MuditaOS.git - switch to the
localization/czechbranch (git checkout localization/czech) - run
missing_strings.shscript to identify which strings still need translating - translate the missing strings
- post the translated strings in a gist
and I'll make sure it all gets merged properly.