Paul Mucur
Paul Mucur
I’ve now distilled this into https://github.com/mudge/re2/pull/138/commits/ac14e8f9af0632f18fe12c568795cc9a9bcd6a7f
It’s worth noting that preferring `$libs` over `$LDFLAGS` seems to cause a problem if you have the library in Ruby’s `RbConfig::CONFIG['exec_prefix']` (a bug @stanhu found when working on re2) so...
You’re welcome, there’s no rush from my side. I had some time this weekend to spend on it hence the over-communication both here and on [my (now draft) PR in...
Quick update: I think I got to the bottom of [why I saw a regression in re2](https://github.com/mudge/re2/pull/138/files#r1538187544) and it _was_ to do with using `have_library("re2")` as it adds `-lre2` to...
Having churned on this a bit, I ended up releasing [re2 2.10.0](https://github.com/mudge/re2/releases/tag/v2.10.0) with the refactored pkg-config logic. In summary: * The previous implementation was mostly taken from Nokogiri’s `extconf.rb` and...
If nothing else, it’d be quite nice to delete my copy of `minimal_pkg_config` and rely on yours if it was made part of MiniPortile2’s public API.
As someone who has benefited hugely from RSpec's generous backward-compatibility with Ruby versions (e.g. in [re2](https://github.com/mudge/re2), [embiggen](https://github.com/altmetric/embiggen), [fieldhand](https://github.com/altmetric/fieldhand), etc.) and has been unpleasantly surprised when other programming languages' test frameworks...