MIDI.js icon indicating copy to clipboard operation
MIDI.js copied to clipboard

Publish MIDI.js as npm module

Open amypellegrini opened this issue 6 years ago • 9 comments

Wouldn't be nice to be able to do npm install midi-js?

I had a fork of the repo and I will do it myself as I will need it for a project of mine, I can send a pull request afterwards, unless the owners have a different idea about this.

amypellegrini avatar Sep 22 '17 13:09 amypellegrini

The module name midi-js is already taken by Microsoft, with and empty (or private?) repo :(

amypellegrini avatar Sep 22 '17 13:09 amypellegrini

Is there a way I can inclue this module in a Github pages site? I'm using it on a web app, but I can't find anywhere to inclue. That said, I'm relatively new to web stuff, so it could just be my idiocy

Loving the module by the way, thank you so much for creating!!

Thanks,

Chris

chrisnorman7 avatar Jan 17 '19 00:01 chrisnorman7

@chrisnorman7 I find a bit difficult to include this as a module in a Github page, since GH pages are static, so the only approach would be to have a copy of the module in your repository, or download it from somewhere through a script tag.

BTW: this is not my repo and I haven't had any time to do what I intended to do yet, so in any case you should thank the owners of this repo!

amypellegrini avatar Jan 17 '19 10:01 amypellegrini

Oh, I would love to thank the owners of this repo, it's amazing!!!

After posting, I did actually find an external version of the script:

I can only assume it's the same version.

HTH somebody.

On Thu, 17 Jan 2019 at 10:02, Amy Pellegrini [email protected] wrote:

@chrisnorman7 https://github.com/chrisnorman7 I find a bit difficult to include this as a module in a Github page, since GH pages are static, so the only approach would be to have a copy of the module in your repository, or download it from somewhere through a script tag.

BTW: this is not my repo and I haven't had any time to do what I intended to do yet, so in any case you should thank the owners of this repo!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mudcube/MIDI.js/issues/219#issuecomment-455113439, or mute the thread https://github.com/notifications/unsubscribe-auth/AENM6QWR30-IqJJ-5Y6KK_VD2WiFPdcEks5vEEoYgaJpZM4PgrZr .

--

Take care,

Chris Norman

chrisnorman7 avatar Jan 17 '19 11:01 chrisnorman7

I have published as an npm module an ES6 modular version of the system as midicube: https://www.npmjs.com/package/midicube (as noted, midijs was already taken as a name, so took midicube as an homage to our great mudcube).

This is my first npm module, so happy to take comments/suggestions/improvements at https://github.com/mscuthbert/midicube

To run from that version directly in a script run:

npm install
npm run build

and then point your <script> tag to build/midicube.js. This will expose the global MIDI which is necessary to load soundfonts. If used within another script, be sure to monkeypatch window.MIDI in order to load soundfonts.

mscuthbert avatar Jul 22 '19 23:07 mscuthbert

This is awesome! Thank you @mscuthbert

amypellegrini avatar Jul 28 '19 03:07 amypellegrini

This is not solved as far as this repository is concerned so I don't think the issue should be closed.

hmoffatt avatar Jul 28 '19 23:07 hmoffatt

I suppose I agree: having this open would help others find the https://github.com/mscuthbert/midicube fork — happy to take further PRs and issues there and give committer access to people who have contributed here to ensure the problem doesn’t happen again down the road.

mscuthbert avatar Jul 28 '19 23:07 mscuthbert

My apologies! I assumed given the previous conversation that there was no intent to take any further action in this repository. Issue re-opened.

amypellegrini avatar Aug 02 '19 15:08 amypellegrini