MaterialFox icon indicating copy to clipboard operation
MaterialFox copied to clipboard

[Feature/element] URL bar completely white

Open inxomnyaa opened this issue 2 years ago • 24 comments

Sanity checks (must complete)

  • [x] I have read and followed the installation instructions in the README
  • [x] I have not modified the userChrome.css file
  • [x] I have tested the latest release for my Firefox version, or commit on master/beta branch (beta is for Firefox Beta only)

Describe the bug The url bar and box appear fully white, making text unreadable

To Reproduce Steps to reproduce the behavior:

  1. Use any theme in the latest version, even defaut ones

Screenshots image

System info

  • OS: [e.g. Windows 10]
  • Firefox version: 100.0b2

inxomnyaa avatar Apr 06 '22 07:04 inxomnyaa

I had the same problem on macOS 12.3.1 with Firefox 100.0b2.

missuo avatar Apr 07 '22 11:04 missuo

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

Lord-Lavios avatar Apr 07 '22 15:04 Lord-Lavios

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

Thanks a lot. I also succeeded.

missuo avatar Apr 07 '22 15:04 missuo

@Lord-Lavios thanks, that worked for me.

mtzfox avatar Apr 11 '22 16:04 mtzfox

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

Worked for me as well, thanks! Just a note that for me it was --toolbar-field-hover-background-color instead of --toolbar-hover-background-color in case anyone runs into this in their variables.css file. The other two variables had the same name as yours though.

juanpabloalfonzo avatar May 04 '22 00:05 juanpabloalfonzo

This theme is the best stlye for firefox, and it is one of the reason that i sitll use firefox not chrome.

melodicwang avatar May 07 '22 12:05 melodicwang

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

I use a Mac, so now it works great in dark mode, but when it switches to light mode the bar stays dark, is there any way to make a real fix so that way it switches between the two like it used to

ghost avatar May 07 '22 13:05 ghost

when it switches to light mode the bar stays dark, is there any way to make a real fix so that way it switches between the two like it used to

I added the following around line 170 in variables.css (under :root:not(:-moz-lwtheme):not([privatebrowsingmode=temporary])):

	--toolbar-field-background-color: rgb(241, 243, 245) !important;
	--toolbar-field-hover-background-color: rgb(232, 235, 236) !important;
	--toolbar-field-focus-background-color: rgb(255, 255, 255) !important;

Grogs avatar May 07 '22 13:05 Grogs

when it switches to light mode the bar stays dark, is there any way to make a real fix so that way it switches between the two like it used to

I added the following around line 170 in variables.css (under :root:not(:-moz-lwtheme):not([privatebrowsingmode=temporary])):

	--toolbar-field-background-color: rgb(241, 243, 245) !important;
	--toolbar-field-hover-background-color: rgb(232, 235, 236) !important;
	--toolbar-field-focus-background-color: rgb(255, 255, 255) !important;
Capture d’écran 2022-05-08 à 23 31 46

It almost worked, matches the colour but now weird translucent results

ghost avatar May 09 '22 02:05 ghost

Any plans to fix this in the latest version of this?

DoNotResuscitate avatar May 13 '22 11:05 DoNotResuscitate

Same issue here image

quarkquartet avatar May 16 '22 05:05 quarkquartet

id argue the color it's meant to be is rgb(28, 27, 34)

privacyguy123 avatar May 16 '22 13:05 privacyguy123

id argue the color it's meant to be is rgb(28, 27, 34)

Still doesn't change the fact that it only works in dark mode

ghost avatar May 18 '22 14:05 ghost

Does anyone actually bother with this? Guess I have to switch to Chrome since this issue essentially makes this theme unusable

Trident6355 avatar May 18 '22 18:05 Trident6355

@muckSponge do you have any insight into what changed with the latest Firefox version to break this?

DoNotResuscitate avatar May 19 '22 00:05 DoNotResuscitate

The CSS selector used to detect a dark theme (:-moz-lwtheme-brighttext) seems not to work anymore: https://github.com/muckSponge/MaterialFox/blob/8b1a7b10da0751a1f63e51eac428ba1eb1094b5f/chrome/global/variables.css#L159-L164 Replacing it with [lwtheme-brighttext] should restore the old behavior.

fmeyertoens avatar May 19 '22 20:05 fmeyertoens

You Sir are a legend. Thank you very much! Fixed it for me.

Trident6355 avatar May 19 '22 21:05 Trident6355

You are GOAT. Works for me.

quarkquartet avatar May 19 '22 21:05 quarkquartet

The CSS selector used to detect a dark theme (:-moz-lwtheme-brighttext) seems not to work anymore:

https://github.com/muckSponge/MaterialFox/blob/8b1a7b10da0751a1f63e51eac428ba1eb1094b5f/chrome/global/variables.css#L159-L164

Replacing it with [lwtheme-brighttext] should restore the old behavior. Capture d’écran 2022-05-20 à 08 49 57 Capture d’écran 2022-05-20 à 08 50 13

Only problem now is that private browsing is off, lol I commend anybody who knows how to code XD

ghost avatar May 20 '22 12:05 ghost

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

fmeyertoens avatar May 20 '22 19:05 fmeyertoens

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

Someone has a good eye, I accidentally slashed the [privatebrowsingmode=temporary]), so apologies for the mixup, this is what it looks like now. Capture d’écran 2022-05-22 à 13 53 56

ghost avatar May 22 '22 17:05 ghost

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

Someone has a good eye, I accidentally slashed the [privatebrowsingmode=temporary]), so apologies for the mixup, this is what it looks like now. Capture d’écran 2022-05-22 à 13 53 56

I think the current correct code should be:

:root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])
{
	--toolbar-field-background-color: #202124 !important;
	--toolbar-field-hover-background-color: #292a2d !important;
	--toolbar-field-focus-background-color: #202124 !important;
}

It works perfect for me.

quarkquartet avatar May 23 '22 20:05 quarkquartet

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

Someone has a good eye, I accidentally slashed the [privatebrowsingmode=temporary]), so apologies for the mixup, this is what it looks like now. Capture d’écran 2022-05-22 à 13 53 56

I think the current correct code should be:

:root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])
{
	--toolbar-field-background-color: #202124 !important;
	--toolbar-field-hover-background-color: #292a2d !important;
	--toolbar-field-focus-background-color: #202124 !important;
}

It works perfect for me.

58786c951d55b9343b314

This is almost perfect, but I think the URL could be a little darker in black in the Light theme.

missuo avatar May 28 '22 14:05 missuo

Thanks for the solutions: just to summarize to anyone reading this thread:

  1. Edit chrome/global/variables.css
  2. Go to line 159
  3. Replace it with :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])

paralin avatar Jun 16 '22 23:06 paralin