motivate icon indicating copy to clipboard operation
motivate copied to clipboard

Add more quotes.

Open mubaris opened this issue 7 years ago • 95 comments

mubaris avatar Oct 10 '17 03:10 mubaris

@mubaris i am working on this. BTW how much quotes should i add ?

harryjas avatar Oct 10 '17 03:10 harryjas

Minimum of 20 :smile:

mubaris avatar Oct 10 '17 04:10 mubaris

I've opened a PR with some quotes for you. Let me know if I need to restructure them. Hopefully they won't collide with @harryjas's work.

jmeline avatar Oct 10 '17 06:10 jmeline

If you are adding more quotes, add 20 quotes in a new json file in data folder. Then make a PR

mubaris avatar Oct 10 '17 06:10 mubaris

can more quotes still be added?. I would like to add more.

hydeenoble avatar Oct 10 '17 06:10 hydeenoble

Yeah. Sure.

On Tue, Oct 10, 2017, 12:07 PM Emehinola Idowu [email protected] wrote:

can more quotes still be added?. I would like to add more.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mubaris/motivate/issues/3#issuecomment-335375345, or mute the thread https://github.com/notifications/unsubscribe-auth/ANOqa6GyUv5QyTxalFU0dB5xgoohGFN3ks5sqxC6gaJpZM4PzUoz .

mubaris avatar Oct 10 '17 06:10 mubaris

Great. on it

hydeenoble avatar Oct 10 '17 06:10 hydeenoble

okay..will add in a new json file..

harryjas avatar Oct 10 '17 09:10 harryjas

I would like to contribute to this project :hand:

AlthafHussainK avatar Oct 10 '17 18:10 AlthafHussainK

Best way to get started is to add more quotes. Fork the repo and add new json file containing 20 quotes. Then send a PR. :smile:

mubaris avatar Oct 11 '17 01:10 mubaris

I've come up with more quotes. Please have a look at it. :smile:

AlthafHussainK avatar Oct 11 '17 07:10 AlthafHussainK

@mubaris I would like to contribute to this.

dhanya1 avatar Oct 14 '17 18:10 dhanya1

i would like to contribute

Curchel avatar Oct 14 '17 18:10 Curchel

This project is awesome! I would like to contribute to this (even though I'm in the beginner level lol).

1st step: Play with it (installing now). :D 2nd step: Find 20 quotes and figure out how to make a json file (I know I should put it into the data folder.)
3rd step: PR - pull a request

I haven't contributed a project on Github before. Although I've already read articles related to "how to contribute to open source projects", you guys can correct me if I do something wrong. >"<

EveChen avatar Oct 15 '17 15:10 EveChen

@EveChen you are good to go.... Awesome!

hydeenoble avatar Oct 15 '17 17:10 hydeenoble

I added some quotes from famous artists about what motivated them to get work done.

JayWelborn avatar Oct 15 '17 20:10 JayWelborn

@dhanya1 @Curchel Everyone is welcome to contribute. :smile:

mubaris avatar Oct 16 '17 02:10 mubaris

I'm on it too!

fercreek avatar Oct 16 '17 20:10 fercreek

Go us!

ghost avatar Oct 19 '17 03:10 ghost

Is there a need for more quotes

maybebored avatar Oct 20 '17 01:10 maybebored

You're always welcome to add more quotes.

mubaris avatar Oct 20 '17 06:10 mubaris

hi there, I would like to also participate in this :). How I can do it?

Pr00bit avatar Oct 23 '17 17:10 Pr00bit

@Pr00bit you can create a new JSON file following the naming format and add a minimum of 20 quotes... :)

hydeenoble avatar Oct 23 '17 17:10 hydeenoble

hi thanks for explanation. Just would have small question - in which location the Json file needs to be upladed/created?

Pr00bit avatar Oct 23 '17 17:10 Pr00bit

OK.....I think there are many dynamics to this. However, when i contributed, I create a JSON file in the "data" folder which is in the "motivate" folder.

hydeenoble avatar Oct 23 '17 17:10 hydeenoble

Thanks for hint, will try to create Json file then :)

Pr00bit avatar Oct 23 '17 17:10 Pr00bit

Hi @mubaris , I added 20 more quotes to the data folder and followed this article on how to contribute. Let me know if this is okay :)

Bubblemelon avatar Oct 23 '17 20:10 Bubblemelon

Hello, Can I add to this?

ghost avatar Nov 05 '17 14:11 ghost

You can use this scrapper to extract more quotes from good reads -

GoodReadsScrapper

abhinuvpitale avatar Nov 05 '17 15:11 abhinuvpitale

How about automating it to collect quotes by itself? @mubaris

thesanjeevsharma avatar Nov 13 '17 17:11 thesanjeevsharma