curiosity icon indicating copy to clipboard operation
curiosity copied to clipboard
verified publisher icon mubaris

ESLINT errors down to zero!

Open alejandronanez opened this issue 8 years ago • 12 comments

We can do this gradually!

Pre requisites.

  • [ ] Merge #17 in V2

alejandronanez avatar Jun 05 '17 09:06 alejandronanez

Yeah, it should be done.

mubaris avatar Jun 05 '17 09:06 mubaris

I think it would be nice to get rid of aaaaall the eslint errors (I think we have a TON). But doing that in one PR maybe too much. I'm ok if we do this gradually, one PR per file or something like that!

For this to be a thing, we need #17 to be merged in V2 first. BTW

alejandronanez avatar Jun 05 '17 09:06 alejandronanez

@alejandronanez Since I'm having some issues, #17 might take more time to finish. I'll try to send a PR as soon as I can.

mubaris avatar Jun 05 '17 09:06 mubaris

@mubaris yeah don't feel rushed about it. I just had this on my mind and wanna make sure I don't forget!

alejandronanez avatar Jun 05 '17 10:06 alejandronanez

Cool

mubaris avatar Jun 05 '17 10:06 mubaris

Hope y'all don't mind if I ran eslint and cleaned up a few of the errors. Have a PR out there with the changes and will start work on the emoji file later.

jearl4 avatar Oct 05 '17 01:10 jearl4

Are all the errors resolved? Or can I contribute as well?

Suneet-M avatar Nov 24 '18 09:11 Suneet-M

is this issue still open? Can I contribute?

paulopacitti avatar Apr 09 '20 23:04 paulopacitti

I would like to work on this. Can you assign this to me?

devcer avatar Oct 01 '20 15:10 devcer

Is this issue still open? I want to contribute, can you assign this to me?

mehargiri avatar Apr 26 '23 16:04 mehargiri

Hello, Is this issue still open to be resolved or can it be assigned to me?

ASP124 avatar Oct 18 '23 21:10 ASP124