mkchromecast icon indicating copy to clipboard operation
mkchromecast copied to clipboard

Re-enable Sonos support in mkchromecast

Open xsdg opened this issue 9 months ago • 1 comments

Sonos support was implicitly disabled as part of the refactor in https://github.com/muammar/mkchromecast/commit/40b3773cf64b73f48ef0bf104c6906d755b4a69a , because the way it was initially added harmed code readability, modularity, correctness, etc.

For anyone wanting Sonos support, you can use the stable branch, or check out a version of the codebase prior to that change.

The solution here is to finish refactoring cast.py (which has its own issues, even regarding Sonos), and then to re-incorporate Sonos support in a way that is sustainable for the codebase.

xsdg avatar May 24 '24 20:05 xsdg