react-radio-buttons icon indicating copy to clipboard operation
react-radio-buttons copied to clipboard

Add props which allow custom styling for button and "selected" button

Open lionel-lints opened this issue 6 years ago • 7 comments

This is a small PR to allow for custom styling to be added so css classes can overwrite the specific styles as needed. I am not sure this is the best solution, but the base case works for me. Happy to update anything upon request as well :-)

A developer could then add a buttonStyling prop and a pointStyling prop to the component which would overwrite any css as needed for both selected and unselected cases.

Added styling to adjust the css for the icon is not provided in this PR, I could potentially do it though in the future.

lionel-lints avatar May 01 '18 16:05 lionel-lints

There seems to be a problem with my pointStyles, updating now...sorry!

lionel-lints avatar May 01 '18 17:05 lionel-lints

OK updated, works for me now, sorry about that!

lionel-lints avatar May 01 '18 17:05 lionel-lints

Hi. Thank you for your PR :) However lib/index.js is transpiled code - i.e. you should edit index.jsx in root folder.

mu29 avatar May 05 '18 08:05 mu29

I see, ok I will take a look when I have some time and ping you back when I can update the PR thanks :-)

lionel-lints avatar May 21 '18 16:05 lionel-lints

Hey, how's this going?

ads-pedroleao avatar Jun 28 '18 14:06 ads-pedroleao

Sorry about the delay, things have been crazy for me, I will try to update this asap and get an updated PR in.

lionel-lints avatar Jul 13 '18 21:07 lionel-lints

Hi, I'm trying those properties, isn't working, no class are added in the html

        <RadioGroup  horizontal onChange={this.onChange}>
          <RadioButton iconSize={20} buttonStyling="primarytoto" pointStyling="test2"  value="optionOne">
            {optionOneText}
          </RadioButton>
          <RadioButton buttonStyling="test" iconSize={20} value="optionTwo">
            { optionTwoText }
          </RadioButton>
        </RadioGroup>

xavierartot avatar Aug 24 '18 19:08 xavierartot