vscode-sqltools icon indicating copy to clipboard operation
vscode-sqltools copied to clipboard

User level "settings.json" is ignore if a local ".vscode/settings.json" sqltools.connections block exists

Open mc-zact opened this issue 3 years ago • 0 comments

Describe the bug A clear and concise description of what the bug is.

I noticed that trying to add global connections in the user settings.json was not working, but adding via wizard which adds them in the workspace level did.

After removing the SQL tools block from settings and reloading I now see the global connections.

To Reproduce Steps to reproduce the behavior:

  1. Edit you User settings.json and add a sample connection, i.e.:
"sqltools.connections": [
        {
            "mysqlOptions": {
                "authProtocol": "default"
            },
            "previewLimit": 50,
            "server": "localhost",
            "port": 3306,
            "askForPassword": false,
            "driver": "MySQL",
            "name": "TEST-1",
            "group": "TEST",
            "username": "username",
            "socketPath": "/tmp/cloud_sql_proxy/sokcet",
        },
        {
            "mysqlOptions": {
                "authProtocol": "default"
            },
            "previewLimit": 50,
            "server": "localhost",
            "port": 3306,
            "askForPassword": true,
            "driver": "MySQL",
            "name": "TEST-2",
            "group": "TEST",
            "username": "username",
            "socketPath": "/tmp/cloud_sql_proxy/sokcet"
        }
    ]

Now add a connection via the Wizard, this will save it in the workspace folder (.vscode/settings.json), the connections added in the global config will go away

Expected behavior Both should show, perhaps grouped by "Global"/"Local", or if this is an intentional feature, perhaps make it optional. On that subject when adding via wizard it would be ideal to state this is being added in the workspace not user (oh btw, if you client "edit settings.json it actually defaults to the user one, which is a bit confusing)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • SQLTools Version 0.23.0
  • VSCode Version: 1.60.2
  • OS: macOS
  • Driver:
    • [ ] PostgreSQL/Redshift
    • [x] MySQL/MariaDB
    • [ ] MSSQL/Azure
    • [ ] SQLite
    • [ ] Other? Which...
  • Database version: [e.g. MySQL v5.6, PostgreSQL vX...]

Additional context Add any other context about the problem here.

mc-zact avatar Oct 05 '21 11:10 mc-zact