Martin Turóci

Results 237 comments of Martin Turóci

I guess it shouldn't be a problem for any of the options, just not sure what is the general practice - cc @lo5

Hm.. although the API allows for `icon`, there is no accompanying implementation. According to https://github.com/h2oai/wave/issues/1067, the proposed design does not include icons, but I would say they can be beneficial....

Agree, however, we cannot get rid of APIwise so I will add a comment to `tall_stats` that icons are not yet supported until we figure out the proper designs. Done...

@mtanco what are you exact python and OS versions? Seems like I am able to get the correct wheel file even with python `3.6.4` and pip `9.0.1` on MacOS `10.15.7`...

Can you also please try specifying the `platform` arg? Could be a possible escape hatch as well. ```sh pip download --platform=macosx_10_9_x86_64 --only-binary=:all: h2o-wave ```

@lo5 this behavior seems to be intentional, see https://github.com/h2oai/wave/blob/31c349df3527569e8e0de0615679a57577fee654/ui/src/ui.ts#L142 Can you clarify or is the line ^^ good to be removed?

Makes sense, what about clearing this only on route (hash) change? This would submit only values related to the currently displayed page. @Far0n the original problem: > Given the following...

This is a bug in the underlying plotting library, tracked in https://github.com/antvis/G2/issues/2549. Reasoning: G2 lib supports 2 types of renderers - canvas and SVG. Wave uses SVG to leverage the...

@sandruparo the proposed design is missing a few parts, please include: * Errors display - e.g. max file size exceeded, unsupported file type etc. * State for single file upload...

Thanks @shihan007, what about the rest of the points? >State for single file upload only. >Display what file extensions / sizes are supported if present.