Mike Turley

Results 57 comments of Mike Turley

the problem is that the hamburger menu should do something differently in mobile mode and desktop mode, with respect to the props you need to pass in stateless (controlled) mode....

Okay, @priley86 @aljesusg this is the method inside VerticalNav that is used when you click the hamburger menu in the default masthead. Overriding it causes this to no longer be...

As for the active page not being set properly, we need to set the `activePath` prop, which is a string matching the `idPath` of a nav item. This is just...

Ok, @priley86 we can do that. Should we also fix this PR so that the masthead works in the demo app in the meantime? I'll open an issue for this...

Not sure when I can get to this, but I created this issue to track it in pf-react: https://github.com/patternfly/patternfly-react/issues/525 I plan to fix this PR soon by lifting all the...

I have a partial fix for this, but still having some trouble with it... My apologies @priley86 ! I'm headed on PTO for my wedding... this will have to wait....

@priley86 if you or someone else has time and can reproduce these issues in Storybook in patternfly-react, maybe we can get the upstream bugs fixed that way.

So I had a free hour and I started debugging this.. The `mobile` prop doesn't need to be set, that's already being done internally by VerticalNav, but `showMobileNav` does need...

@priley86 I pushed a fix for the feedback on #43 in #45 :) and thanks for merging https://github.com/patternfly/patternfly-react/pull/539. I'm back from PTO and I'll try to finish fixing this before...

@priley86 here is a fix for the remaining problem with the expand/collapse on mobile: https://github.com/mturley/patternfly-react-demo-app/commit/53d87c9057ed37266dc841c663bf30201c353e3d If we merge #45, rebase this branch on master, and cherry-pick that commit, I think...