Marco Braga

Results 224 comments of Marco Braga

updating improving the expected test failure to force to skip instead of passing: /test pull-cloud-provider-aws-e2e

> updating improving the expected test failure to force to skip instead of passing: > > /test pull-cloud-provider-aws-e2e I also removed the internet-facing tests that does not make sense to...

This PR is ready for review. In the latest version I reviewed: - SCC to fit CI constraints running with non-root - improve the doc strings of new functions -...

> looking mostly good, i just have a question about the global variables. Thanks, @elmiko, good suggestions. Fixed.

Hey @cartermckinnon , would you mind taking a look at this e2e test improvements to help us troubleshooting known issues? This won't fix https://github.com/kubernetes/cloud-provider-aws/issues/1160, but help us test it. Thanks!

> @mtulio Hi, thanks for the contribution. Just for my understanding, this PR mostly adds the test coverage for internal NLB hairpin issue, but in the test case itself we...

Hi @oliviassss @kmala , would you mind also triage the related issue https://github.com/kubernetes/cloud-provider-aws/issues/1160, please?