signpost icon indicating copy to clipboard operation
signpost copied to clipboard

Published 20 hours ago • verified publisher icon mttkay

Apache httpclient5 support

Open kjozsa opened this issue 3 years ago • 9 comments

Hi Matthias,

we are using hcclient5's ClassicHttpRequest in our project and I needed an OAuth1 lib badly.. The fastest way seemed to be adding support for this in SignPost. I cleared up my PR, I hope it makes into the base project!

Should you have any comments or change requests regarding this code, let's get in touch..

cheers, Kristof

kjozsa avatar Feb 15 '22 13:02 kjozsa

Hi, thanks for your contribution!

I have not maintained this repository in many years, but I see @simon04 has done so more recently -- do you have capacity to look at these changes Simon?

mttkay avatar Feb 17 '22 06:02 mttkay

Hi @simon04, do you think you could review these changes some day? Thanks much..

kjozsa avatar Feb 23 '22 09:02 kjozsa

@kjozsa Is there any thought of adding support for the HttpAsyncClient5 as well?

aakarshsingh avatar Feb 23 '22 09:02 aakarshsingh

tmp_1645645179580.jpg

Here is the class layout for both classic (in blue) and async (green) methods of Apache 5. Theoretically, should be able to sign a 'BasicHttpRequest' to serve both types.

aakarshsingh avatar Feb 23 '22 19:02 aakarshsingh

Hi all, I implemented full hcclient5 support, sync + async support are both ready now in my PR.

Note that for the unit tests I needed to bump Mockito to v4 and JUnit to the latest 4.x. I aimed for minimal changes, but this required updating a few more classes around the codebase..

Please review my changes and accept my contribution if satisfied.

kjozsa avatar Mar 08 '22 12:03 kjozsa

This looks amazing. Thanks, @kjozsa.

I hope one of the maintainers can look at this soon.

aakarshsingh avatar Mar 08 '22 17:03 aakarshsingh

@mttkay what do you think? Also, can you please help reaching out to @simon04?

kjozsa avatar Mar 16 '22 14:03 kjozsa

How is update?

HMAC-SHA1 will no longer be accepted as a signature method for TBA integrations. Before your account is upgraded to 2023.1, you must update your TBA integrations to use the HMAC-SHA256 signature method.

yokikathir avatar Jun 15 '22 09:06 yokikathir

I don't want to show up as the drama queen in this story, but my conclusion is that it's a waste of time. No repo owners showed up or has shown any sign of interest in merging that code, so it probably makes no sense to push more energies into this.

kjozsa avatar Jun 15 '22 09:06 kjozsa