Mateusz Sokół
Mateusz Sokół
> @mtsokol Is this still relevant? Let's leave it open for now. For power iteration we have HITS example, but once we have `diagonal` this will be a fine addition...
I think no-op support for bool dtype also makes sense to me.
It's ready for another review! (I think CI failures are unrelated as they occur in other PRs as well.)
@seberg I added no-op for boolean dtype - it's completed from my side.
@mikeurbach I took a look at it and it seems that for other dialects, Ops (and respective folders) provide additionally a signedness, like in [HWArith](https://github.com/llvm/circt/blob/efd1a3257ee1a26b9d11bf709fd9fee30f822900/lib/Dialect/HWArith/HWArithOps.cpp#L154). In my folders to construct...
> Can you let us know if using micromamba 2.0.4 and setup-micromamba 2.0.2 fixed this problem? It's also fixed in `pydata/sparse`. Thank you!
> the current `ph.assert_*` helpers go to incredible lengths to give useful diagnostics. Maybe we could improve specific helpers? You mention `test_repeat`, do you happen to remember other cases with...
Would it make sense to require `reshape`, `asarray`, `zeros`, `isnan` to run the test suite? These ones could be considered essential.
> You mean add a note to this effect to the "Interpreting errors" section of the README? https://github.com/data-apis/array-api-tests/blob/master/README.md Yes, I think a note listing which functions are essential to run...
I think the only part of pass infrastructure rewritten here is `rewrite_tools.py` taken from Julia Finch. The rest is scheduler logic (passes, IR). I used egglog for the first try...