Mattias Granlund
Mattias Granlund
Hey sorry for the delay, but great work! I've added some feedback. Would you mind having a look and then I'll try this out locally? *edit: @PavelLaptev would you mind...
Sorry for the delay, but this is great stuff. 🎉 I also love the attention to detail in e.g. how when you resize beyond min-width it switches state to collapsed....
Closing this since this is an `rxjs` issue and we have completely removed that.
@krlvi I should perhaps know the answer by now, but what is the difference between "upstream commits" and commits on "remote branch"?
Looking really solid 💪
For things operating on git like `gitGetConfig`, could we integrate them into an existing service or create a new one? I think we want to stick with using dependancy injection...
Great progress! 💪
Just leaving a note that I'll review the new changes as soon as I get a chance!
I just sat down to look at this again. Sorry for my absence, I was deep in the weeds trying to wrap my head around both streams and dependency injection....
@Caleb-T-Owens hey, sorry, I pushed here even though I meant to push to my own branch. I didn't realize GitButler can push to other peoples' forks. :) Anyway, feel free...