Matt Triff comments

Results 37 comments of


                                            Matt Triff

Choices renders HTML Invalid code

Thanks for flagging this. Happy to review a PR for this!

Feat/allow to be imported on server

This seems reasonable. Can you rebase on the latest version of `master` and add an e2e test for server side rendering? [This](https://glebbahmutov.com/blog/ssr-e2e/) seems like a possible approach to that.

use data-custom-properties

I can duplicate this issue. It looks like it is a regression and will need to be fixed. Also, you may want to use [events provided by Choices](https://github.com/Choices-js/Choices#events) instead of...

Trigger changeQuery event when user inputs something into the search field

This looks like a great addition, but right now it won't function as intended. A `changeQuery` event will be fired every time a key is pressed, even if it doesn't...

Provide an option to track options from underlying select element

I'm open to exploring this, I see why you'd want this functionality. I'd probably go with the `refresh` method route you mentioned. How do you propose handling cases where a...

close by click on open dropdown

You can implement this using [hideDropdown](https://github.com/Choices-js/Choices#hidedropdown).

close by click on open dropdown

Why is that necessary? You can run `hideDropdown` whether or not the dropdown is open or not. Regardless, you can check whether it's open or not by accessing `choicesInstance.dropdown.isActive`.

Tree (dir) structure

That's a cool feature! PRs welcome.

Scrolling to bottom of window when opening dropdown with spacebar

@brada1703 a pull request would be great!

collectCandidates fails when seeking the tokenStream

I also ran into this issue, due to a cold token stream. I think defaulting currentIndex to 0 if `tokenStream.index` is -1 should be the easy fix. I don't see...