Manuel

Results 1818 comments of Manuel

It seems to pass! Please request a review whenever this is ready.

@faisal154 @fn-faisal is this ready for review? it would be great if we could get this merged and then close the related dashboard issue.

@fn-faisal It seems that some tests are still failing, could you take a look? And maybe comment on the open review questions, so we know which ones are done. I...

@fn-faisal some tests are flaky, we can just ignore them in this PR.

@fn-faisal Apologies for the delay, I should look over this over the next days, it's quite a big (and great ;) PR.

Right, it already exists, there is even a test case: https://github.com/parse-community/parse-server/blob/4c29d4d23b67e4abaf25803fe71cae47ce1b5957/spec/index.spec.js#L489-L508 If the test already passes, why is this PR needed?

What's the difference between your example and the test?

@okobsamoht could you take a look at this PR to get this ready for merging?

Resolving the open comments. There is an open discussion about stale auth data in the advisory.