laravel-swagger icon indicating copy to clipboard operation
laravel-swagger copied to clipboard

Fix PHP8 deprecation in `Generator::getFormRules`

Open viki53 opened this issue 3 years ago • 4 comments

Fixes mtrajano/laravel-swagger#60

To anyone already using this repo and needing to use this fix for the time being, you can use the following info in your composer.json:

    "repositories": {
        "laravel-swagger-php8": {
            "type": "package",
            "package": {
                "name": "mtrajano/laravel-swagger",
                "version": "0.6.5",
                "source": {
                    "url": "https://github.com/viki53/laravel-swagger.git",
                    "type": "git",
                    "reference": "origin/master"
                }
            }
        }
    },

This will override your version with my repo without needing to change your dependencies list, that way you can just remove this config later when this repo is updated with the fix.

viki53 avatar Mar 09 '21 17:03 viki53

Hi @viki53 can you please add 8.0 and 8.1 to .travis.yml so builds are run for those versions?

MaFx avatar Mar 14 '22 07:03 MaFx

Done!

Let me know if there's anything else I can do to help :)

viki53 avatar Mar 14 '22 08:03 viki53

Hey @viki53 thank you for the pr, sorry I didn't get around to it sooner. I think there's still a few things clashing with 8.1 (At least one of them being that ArrayAccess::offsetExists now has a return type), might just be about adjusting the versions of passport and testbanch as well. Going to take a look a little bit later today and see if I can resolve those as well and fix these all at once

mtrajano avatar Mar 14 '22 19:03 mtrajano

@mtrajano Hi, sorry to bother you, is there any news? Do you need me to update/fix something?

viki53 avatar Jul 25 '22 09:07 viki53