read-time icon indicating copy to clipboard operation
read-time copied to clipboard

Cached config throws error

Open mbardelmeijer opened this issue 2 years ago • 0 comments

Using this package with a cached config (php artisan config:cache) & using the default config from the package throws the following error:

Argument 1 passed to Mtownsend\ReadTime\ReadTime::omitSeconds() must be of the type bool, null given, called in vendor/mtownsend/read-time/src/Providers/ReadTimeServiceProvider.php on line 54

I think this is due to the config being loaded in the binding. I think the mergeConfigFrom should be in the boot method of the service provider.

mbardelmeijer avatar Aug 30 '21 12:08 mbardelmeijer