node-system-icon icon indicating copy to clipboard operation
node-system-icon copied to clipboard

Published 20 hours ago • verified publisher icon mtojo

fix on node 12/13 (hopefully)

Open foxt opened this issue 5 years ago • 3 comments

This seems to work on NodeJS 13, at least on macOS Catalina. This is my first time ever working with node-gyp so please excuse any glaring mistakes!

foxt avatar Mar 03 '20 12:03 foxt

This fix seems to be working like a Charm.

I'm using node 13.12.0 on OSX 10.15.5

andrespagella avatar Jun 29 '20 06:06 andrespagella

I like it, it installs on Node 12+.

However I cant seem to get this to work in an electron environment. It's complaining about addon.node could not locate the binding file.

tance77 avatar Oct 05 '20 20:10 tance77

I opened a pull request to solve the addon.node thing. Also it solved a build issue with node-gyp and msvs compiler flags on windows. I PRed it to this PR maybe I should just fork the main repo instead, but it used your Node12+ changes.

tance77 avatar Oct 08 '20 22:10 tance77