greenwall icon indicating copy to clipboard operation
greenwall copied to clipboard

add docker support

Open llitfkitfk opened this issue 6 years ago • 7 comments

llitfkitfk avatar Jan 10 '19 03:01 llitfkitfk

Hi @llitfkitfk

Thank you very much for your input! Shall I ask you to fix the Travis build as well?

mtojek avatar Jan 10 '19 15:01 mtojek

Another comment, any reason why you've enabled "go mod"? I wouldn't say no, but not as a part of this PR.

mtojek avatar Jan 10 '19 19:01 mtojek

go mod for docker build download dependencies and build greenwall command

llitfkitfk avatar Jan 11 '19 02:01 llitfkitfk

if some dependencies have breaking changes, docker build could be failed I think

llitfkitfk avatar Jan 11 '19 02:01 llitfkitfk

Generally l'm fine with your changes, but please fix the build on Travis, then I will merge it. Thanks!

mtojek avatar Jan 11 '19 07:01 mtojek

I think go mod need added the first time

llitfkitfk avatar Jan 11 '19 09:01 llitfkitfk

Ok @llitfkitfk, so kindly please prepare a PR (with go mod only) that passes the Travis build.

BTW Later on, you can update README file with section about Docker.

mtojek avatar Jan 11 '19 13:01 mtojek