geoip
geoip copied to clipboard
mtodd
Use MaxMind Supplied Test DBs
I've contacted MaxMind and they've been gracious enough to provide us with test databases that we can distribute along with the client library to simplify testing. This pull includes these new files and slight refactoring to the tests.
This also includes a fix for #7 that only attempts lookups of region_name when region is found, which was previously causing segfaults.
Awaiting some updated test DBs from the MaxMind contact (to get the tests passing) and some further details before merging.
While we await these test DBs from MaxMind, this gem crashes (see #7). Are the test DBs worth blocking a fix for a fatal error condition?
Is everyone still using this gem? If segfault-fixes are not being merged on this project, is there another that you all are using? We've been using our own fork, but we thought that would be temporary.
@mtodd, I don't feel like I have the time or expertise anymore to maintain this gem. Thoughts on inviting new maintainers from the folks submitting pull requests?
@alindeman I would be interested, but I've been using the geoip-c gem, and unless there is a compelling reason to maintain this one, I'll probably pass.
@alindeman I was clearly confused in my reply. This is the geoip-c gem, and I guess I thought I was responding to a different request.
That said, I am interested in maintaining this gem, as this gem deserves more attention.
Right, this is the geoip-c gem. I'm :+1: to make you a committer. I'm not using this gem day-to-day anymore, so I'm not a good candidate to keep things moving. @mtodd has the final call though.
Cool. Hopefully @mtodd will chime in here. By the way, @alindeman, are you using any geo data anymore, and if so, what gem are you using to access that data (out of curiosity)?
By the way, @alindeman, are you using any geo data anymore, and if so, what gem are you using to access that data (out of curiosity)?
Ah, I'm just not currently working on a project that uses an IP -> geo database anymore. I believe the project itself is still using this gem, but other folks are working on it now.
I'm very eager to find someone to take over maintaing this gem. I simply don't have the time or attention to properly care for it and know that that won't be changing any time soon.