Mike McCrea
Mike McCrea
Interesting...this relates to the use of ControlNames for variables... ```supercollider { Impulse.ar(\tFreq.kr(400)) }.plot(0.01) ``` ``` ERROR: Message 'addKr' not understood. RECEIVER: nil ARGS: Symbol 'tFreq' Integer 400 ```
Actually, this isn't related to Plotter, it's the routine that's throwing the error: ``` { Impulse.ar(\tFreq.ar(400)) }.fork //plot(0.01) ``` ``` Object:doesNotUnderstand arg this = nil arg selector = 'addAr' arg...
I mentioned the wrong variable in my previous post, you're right that `buildSynthDef` is the problem. It should answer with the `SynthDef` that is currently being built.
@telephon, yep looks the changes in #6235 are functionally the same as #6217, though the latter adds a bit of extra documentation and cleanup. The exception is the nil check...
Or the commit with identical changes, 4a783f1865b613436316f2b094283dc70771527e, could be scrubbed from #6235, then there's no conflict and they could just both be merged at the same time.
To clarify, commit 4a783f1 in your branch has changes identical to those in mine, but the corresponding commit in my branch has [additional changes](https://github.com/supercollider/supercollider/pull/6217/commits/de869e1f00eedc82521991ae184bc8d7aadb06b4#diff-da6b2a4d5d4fc158a276a99295d3c4009f1c182dbe7c1d1c97c0baad1e576b1b). So I'm suggesting that 4a783f1 be...
Good suggestion, I've updated my version. So you'll remove the corresponding commit from your PR, or would that just be handled by merging #6217 after #6235?
I linted your changes and there's just some minor formatting changes needed. You'll just need to [run clang-format](https://github.com/supercollider/supercollider/wiki/Cpp-formatting-instructions).
If you don't yet have it set up and want to just get tests to pass, here's what the formatted changes look like: https://github.com/supercollider/supercollider/commit/243e51f06c994a1ec036c7c809b1e03a27f688f0 But for future contributions you'll definitely...