Mike McCrea

Results 215 comments of Mike McCrea

@brianlheim `QtGUI.palette` is still used, perhaps I'm not understanding your concern. Could you elaborate? I'm not that familiar with palettes, but happy to make changes if you prefer. > i'm...

Hi @joshpar yes I have a fix now but I was intending to do a bit more testing. It took some time because it has uncovered other issues with plotter,...

While I haven't had time to wrap up testing on this, I thought I'd at least see what folks think of the proposed new default colors. @brianlheim and @jamshark70 brought...

>If the system palette follows OS settings Doesn't seem to... I get the `light` palette regardless of my system settings. I am only able to test on Mac though.

I thought I'd have a quick look at this again to see if I could wrap it up. It's been a while so I'm going off of notes I made...

Thanks @telephon I may have a look at the larger architecture in the future, but for now I’ll limit the scope of the PR because I haven’t been able to...

> @mtmccrea @telephon what's the status of this PR? It's ready for review. Because this is a change to the visual appearance of plots, I would hope others might run...

After rebasing, it looks like this will need some more work, so unfortunately it needs to wait. I made a [draft change](https://github.com/mtmccrea/supercollider/commit/b003f147ad09002f0bd24f11bf01ff116471b8af) that addresses @telephon's suggestion, but I'll need to...

@dyfer > Sorry I wasn't clear. When the system palette is used, do the actual colors change with the change of the system theme between light and dark? And with...

Update: this had failing tests (random configuration errors in CI) which prevented all tests from running. After re-running those jobs, it revealed one legit failing test, and that's been resolved....