Mike McCrea
Mike McCrea
> Might it be worth removing the label 'Work In Progress (WIP) do not merge yet'? We could migrate those prs with the label to drafts? I agree in principle,...
Good idea. I understand you to mean using the recommended commit message format (as opposed to assigning a label to the PR), correct? Updated with a note about commit message...
>All commits should at least have a comp: label. Perhaps you meant to say all PRs should have... Commits are also recommended to have a message format beginning with a...
I tried moving the note about commit message to the top and it was just distracting. It's the kind of thing you really only need to see once or twice,...
Merging Reviewer, please squash!
>Ah, I don't remember why it seemed necessary at that time. Looks like there may have just been some [mixup in commit revisions](https://github.com/supercollider/supercollider/commit/ade89a7555739d4ce405cc322b02b44a93b73b6a#commitcomment-5853764) and the change ended up in two...
I modified the provided example to hopefully make the problem it a bit clearer: ```supercollider s.boot; // server must be booted for del calculation below... ( { var impulse =...
I see a couple of issues in the source: First, it looks like the logic for setting the calculation function in Phasor's Ctor, checks if the rate of the ugen...
Here's what I did to fix it, both `Phasor_Ctor` and `Phasor_next_kk` have been changed: EDIT: removing this suggested fix, as the issue proved to be elsewhere.
> examples are resetting to 3 — is that correct? Yes, sorry that was a typo. I've corrected the post. > These examples don't add the input at all when...