Mike McCrea

Results 215 comments of Mike McCrea

@prko Is there a reason to support _both_ LaTeX and MathML, considering they both achieve the same goal of rendering math? Would supporting one or the other make the footprint...

The important question is > Would supporting one or the other make the footprint of this library smaller or make the implementation in the SCDoc renderer simpler? Choosing one or...

> To use LaTeX in SCDoc we do not need anything else. > I also thought it would be better to remove MathML, because it is too long to type...

I'm in favor of adding the `bounds_` method to Stethoscope, but not making modifications of the requested size based on screen bounds. The reason is that we found previously that...

Please add documentation for the added method. Note for the description of the argument that: `rect` can be a `Rect` or anything that responds to `.asRect`. For example the scope...

> an object with a setter should also have a getter. Good point! I noticed the method documentation listed a return value, though there isn't yet actually a getter method.

Thanks, @prko, for all your work on getting this sorted, it's looking good! I'll leave final approval to @telephon, who started the original review.

>Have in mind that @dyfer is already working on Qt6 support, see https://github.com/supercollider/supercollider/compare/develop...dyfer:supercollider:topic/qt6-11 - maybe it is best to get in contact with him and ask what steps are missing...

Please add a description of this PR, rather than linking to another, as this is now separate from that one.

I'll reiterate my comment from the previous PR: IMO modifications of the requested size based on screen bounds is error prone and may surprise the user. We found previously that...