Mike McCrea

Results 215 comments of Mike McCrea

Good point, @timblechmann. I think the audio-rate case is more common and has lead to more bugs/unexpected behavior (I've listed a few bugs this fixes in the description), but the...

> but it's more the semantics of a signal: e.g. an audio-rate signal could very well be a frequency for fm/pm or a vcf. I agree. I'm hoping the defaults...

To be more clear on my thinking for the default values, just based on my experience/assumptions: 1. When running at audio rate, we can more safely assume "audio" signals, so...

I've updated the implementation so that predelay samples are now arguments. As described above, default predelay samples are `0.0` for `ar`, and equal to the first input sample at `kr`....

OK, now unit tests have been added, docs updated, and the description above has been updated to include the implementation notes.

> just a typo, I think. Ah, thanks for catching that, sorry to have missed it! Updated...

Would anyone like to make the merge on this? There have been a number of eyes on it and I think it's been thoroughly fleshed out at this point. The...

Should this link to the wiki page [specifically about filing issues](https://github.com/supercollider/supercollider/wiki/Reporting-bugs%2C-issues%2C-feature-requests), or the [Contributing directory](https://github.com/supercollider/supercollider/wiki/Contributing-directory), which has a collection of useful/related links? The previous [CONTRIBUTING.md](https://github.com/supercollider/supercollider/blob/17c81aedc3528f64864394faf38aa09e1dea2231/CONTRIBUTING.md) had info on all things...

I can't see a settings tab on the repo to access the template, I think [someone with owner status](https://github.com/orgs/supercollider/people) would need to do this. ~~I'd be happy to do this...