Mike McCrea
Mike McCrea
Since this PR fixed a handful of unit tests in `TestCoreUGens: test_ugen_generator_equivalences`, I've re-enabled that suite. Theres now just 2 unit tests in that suite that fail—`Duty` tests—so I commented...
@JordanHendersonMusic could you confirm I addressed your concern with the unit tests? Otherwise I think I've addressed everything in the comments/reviews and this should be ready to go.
would anyone like to give this an "official" review?
Sorry I haven't yet gotten to this one yet, it's [the list](https://github.com/mtmccrea/supercollider/wiki/UGen-Fix-List). Just finished up the _LFUGens.cpp_, _FilterUGens.cpp_ is next, I'll bump the Decays toward the top of the list.
Fixed by [#6194](https://github.com/supercollider/supercollider/pull/6194)
Still waiting on a review :-/
> Oh, nice! Any idea when the fix could be merged? @TatriX note this fix to Decay/2 has been merged into `develop` (no timeline yet for main release though). Thanks...
Reminder to merging reviewer: relies on the merge of #6110, which fixes Delay1
The dependent PR is now merged, so this one is ready for merge as well now.
I agree `Buffer.alloc` is the standard way and is preferred in 95% of cases. There are still cases to instantiate the object without a corresponding server-side object, even though it's...