Mike McCrea

Results 215 comments of Mike McCrea

@sirlensalot sorry I meant to mention this earlier—it looks like your editor is scrubbing newlines from the eof, creating a bit of whitespace noise in the commits. Probably best to...

Nice catch! Looks good. I'll circle back around and approve in a few days if there aren't any concerns raised in the meantime...

> Note there are failing tests for Duty in `TestCoreUGens` Unless I'm mistaken because there are still other (unrelated) failing tests in `TestCoreUgens`, we wouldn't want to remove this yet.

Thanks, @mossheim. > is there any plan for further testing I try to do tests with a variety of argument rates, etc. for each UGen: https://github.com/mtmccrea/supercollider/wiki/UGen-Fix-List#notes-on-testing-technique So I'd consider my...

The tests are manual. I have a template, but unfortunately each one requires manual setup specific to each UGen. >OK, so it is not a problem if we release a...

> What do you mean? Are you instrumenting the C++ code somehow or using additional tooling? My template is in SC, it generates multiple function calls for the UGen under...

Pinging on this batch of initialization fixes. It would be great to have this review completed— these changes fix a number of unit tests that have been broken for a...

> I'm not sure if it would help to add a few more tests? Since this changes subtle behaviour it would be good if one could understand (and fix) these...

> @mtmccrea I _think_ its the existing unit tests that check for initialisation that are often flaky when ran on through CI. Might want to be extra careful how they...

OK I managed to get formatting working (and made a [janky update](https://github.com/supercollider/supercollider/wiki/Cpp-formatting-instructions#requirements) to the wiki... which should be more properly updated).