mtlynch
Add cat lock <lock-id> command
Contributing process
- [x] I understand that this is some guy's personal hobby project and reviews are on a best-effort basis
- [x] I've read the contribution guidelines
What type of PR is this? (check all applicable)
- [ ] Refactor
- [x] Feature
- [ ] Bugfix
- [ ] Optimization
- [ ] Documentation Update
Description
Adds the possibility to fetch data for a specific lock.
Did you update the API documentation?
- [x] Yes
- [ ] This change does not require documentation changes
- [ ] I need help updating documentation
Have you added or updated tests?
- [x] Yes, I added unit tests
- [ ] Yes, I added end-to-end tests
- [ ] No, and this is why: please replace this line with details on why tests have not been included
- [ ] I need help writing tests
@crazymind1337 - Thanks for contributing. You don't need to reset and force push, as I squash and merge all PRs. Force pushes actually make it kind of harder to review.
Well the tests are failing and I have to make them work right? Thatswhy I am forcing-pushing. Thats my usual workflow.
Force pushes actually make it kind of harder to review.
Why? In the end there is just one commit you require to review. Those other overwritten commits don't exist anymore.
Force pushes actually make it kind of harder to review.
Why? In the end there is just one commit you require to review. Those other overwritten commits don't exist anymore.
You pushed about 15 commits. Obviously, something was tripping you up, but because you kept force pushing, I couldn't easily see what was changing from commit to commit. It's helpful if I know what's causing you to keep hacking away at the same PR.
Also, in general, if you're contributing to an open-source repo and the maintainer asks you to stop doing something, it's polite to honor the request even if you don't understand it.
Well the tests are failing and I have to make them work right? Thatswhy I am forcing-pushing. Thats my usual workflow.
You can do this without resetting and force pushing. Make a new commit with your fix rather than resetting to rewrite your previous commits. Is there a reason that doesn't work for you?
Force pushes actually make it kind of harder to review.
Why? In the end there is just one commit you require to review. Those other overwritten commits don't exist anymore.
You pushed about 15 commits. Obviously, something was tripping you up, but because you kept force pushing, I couldn't easily see what was changing from commit to commit. It's helpful if I know what's causing you to keep hacking away at the same PR.
Also, in general, if you're contributing to an open-source repo and the maintainer asks you to stop doing something, it's polite to honor the request even if you don't understand it.
Well the tests are failing and I have to make them work right? Thatswhy I am forcing-pushing. Thats my usual workflow.
You can do this without resetting and force pushing. Make a new commit with your fix rather than resetting to rewrite your previous commits. Is there a reason that doesn't work for you?
Well from my point of view it is not required to see all changes (which in my case have been mostly syntax or linting issues). Just the end result is important. I am not very experienced in python so many pushes have been required to make the pipeline green. But if you prefer many tiny commits I can make it that why. I think we both have just different ways of working :D