scryer-prolog icon indicating copy to clipboard operation
scryer-prolog copied to clipboard

New top-level

Open mthom opened this issue 3 years ago • 4 comments

This is a continuation of @notoria's work on a new top-level.

mthom avatar Apr 07 '21 02:04 mthom

Thank you a lot, @notoria and @mthom! This also solves #888.

One issue I noticed is the indentation of the last line in:

?- member(X, "abc").
   X=a
;  X=b
;  X=c
;     false.

triska avatar Apr 07 '21 15:04 triska

Also, please credit @notoria in the commit message!

@notoria : I hope you are OK with it? You took the initiative and did most of the work for this huge improvement!

triska avatar Apr 07 '21 16:04 triska

@triska : It's fine.

The Prolog printer is likely to introduce new issues in the future, write_term/2/write_term_to_chars/3 with quoted(true) seems to be a better alternative (more mature):

?- op(100, fy, @).
   true.
?- op(100, yf, #).
   true.
?- X = @(x#), Y = (@x)# .
   X= @x#, Y= @x# .
?-

While the expected answer: Y=(@x)#.

ghost avatar Apr 07 '21 16:04 ghost

Also, please credit @notoria in the commit message!

Tip, you can use Co-authored-by to attribute shared work.

tniessen avatar Apr 07 '21 17:04 tniessen