scryer-prolog icon indicating copy to clipboard operation
scryer-prolog copied to clipboard

Improvements to predicate_property/2

Open triska opened this issue 8 months ago • 4 comments

The motivation for this is #2898.

However, throwing instantiation errors for variable module leads to Scryer crashing on startup. This must be addressed before merging.

If anyone has any input on this, I would greatly appreciate it. Thank you a lot!

triska avatar Apr 21 '25 19:04 triska

The commit history makes it very hard for me to tell what's going on in this PR. I think rebis-dev must have been rebased after this PR was created. If it's not too much trouble, could you please rebase this PR?

rotu avatar May 16 '25 02:05 rotu

Look at the changes from just the last 2 commits: https://github.com/mthom/scryer-prolog/pull/2902/files/9acaeb38efa741633ebd76a1b05a7de19a37f8c2..afc3aa253a631d52161640338553c42ce5a3c547

bakaq avatar May 16 '25 02:05 bakaq

@bakaq Thanks, you're right. Those commits even cherry-pick cleanly onto master.

rotu avatar May 16 '25 02:05 rotu

BTW, if you drop the rebis-dev commits from this branch, GitHub Actions still default to running against the anticipated merge:

https://github.com/mthom/scryer-prolog/actions/runs/14579523803/job/40892946221?pr=2902#step:2:62> Checking out the ref

/usr/bin/git checkout --progress --force refs/remotes/pull/2902/merge

That is, it's cleaner to fork master (or some commit you expect to never get written out of the history), even if it's not the branch your PR targets.

rotu avatar May 16 '25 17:05 rotu