Mathias Thierbach

Results 119 comments of Mathias Thierbach

Consider using https://github.com/kthompson/glob instead of custom Regex.

Ref: https://github.com/dotnet/runtime/issues/21362

Does your PbixProj folder contain a data model? In that case you'd have to compile into a .pbit (`-format PBIT`). If it wasn't that, and you tried to compile a...

Let me check that. It's supposed to fail with "File Not Found" in this case.

@didierterrien The "No Action Specified" and "File Not Found" errors are raised by PowerArgs, a project dependency: https://github.com/adamabdelhamed/PowerArgs, that's why you won't find those references in the `pbi-tools` source code.

https://docs.microsoft.com/dotnet/api/system.diagnostics.process.exitcode is the best solution. By (universal) convention, a zero exit code indicates success, all other codes mean an error occurred. pbi-tools defines specific, typed, exit codes here: https://github.com/pbi-tools/pbi-tools/blob/662675e5bf8f494f21127dbc7d6a20829672bfbc/src/PBI-Tools/Program.cs#L169

See https://github.com/dotnet/winforms/issues/2059 for further reference on embedding an application manifest using the .Net Core SDK.

Rick has it all covered nicely here: https://weblog.west-wind.com/posts/2022/Jan/03/Integrating-Long-Path-Names-in-Windows-NET-Applications _Extended Paths_ are an alternative. Consider an opt-in setting?

Long path support in Windows is tricky. The standard solution requires two changes, one on the user side (which you've made), but also another in the application (`pbi-tools` in this...

@agusmba I wonder whether in this case a folder name trim rule might be the right solution? You'd configure a max length for page/visual folder names, and if the actual...