Matt Thalman

Results 294 comments of Matt Thalman

This work requires the [ACR Caching feature](https://learn.microsoft.com/en-us/azure/container-registry/tutorial-registry-cache) which is currently in preview. The preview release doesn't support using an ACR as the upstream source which is what would be required...

Need to update the logic to include more logging so that we can see the path it's attempting to use as well as the paths it's queried to derive the...

> I was playing around with the dev UX a bit and was surprised at the overhead prior to when it appears to actually build the test projects in a...

> One, why is build even happening - is there not a way to avoid rebuilding? That's what the `--testnobuild` option is for.

I've addressed all comments. There was also a bunch of changes needed to integrate with the changes from https://github.com/dotnet/installer/pull/19290. This is mostly done in https://github.com/dotnet/installer/pull/19222/commits/2621b96ed1f9077757b089187b767b87e23a136f. That removes the explicit invocation...

> I just noticed that scenario-tests aren't build or run on Windows, presumably because of the `__PortableTargetOS` condition. That variable is only set in build.sh. Fixed in https://github.com/dotnet/installer/pull/19222/commits/9745f7ad22ade03719c6882e91d31ba4070078bf

There are issues getting the scenario tests working with the DevVersions leg for the UB pipeline. There are a few issues with it: * It requires the use of the...

Note to reviewers: I really need to wrap up this PR so I can focus on other work. If you identify functional issues with these changes, I will continue to...

A new error is showing up from the Aspire test. This isn't specific to my changes. I can repro it using the latest built SDK from the unified build pipeline....

> A new error is showing up from the Aspire test. This isn't specific to my changes. I can repro it using the latest built SDK from the unified build...