netrunner
netrunner copied to clipboard
mtgred
modifies engine to accept ability-title as an input parameter for events
This is probably not the best way to do it, but tbh that entire system seems a bit confusing to me.
This should allow multiple events on the same card with the same timing to be named and arbitrarily fired in any order. It also means you can name some of the triggers, though I'm not sure we need it right now.
I'll figure out a cleaner way to write this a bit later, just had to put it up while I remembered.
No worries.
Here's a simple example where the (1996) card 'Butcher Boy' registers a handler against the runner ID (it needs to persist indefinitely, even if the card vanishes). Since it's registered under the ID, it's competing with MaxX to trigger first.
Prior to this change, you wouldn't be able to distinguish the triggers or pick which trigger to resolve first.
I probably still need to rewrite this to be a bit less hacky.
This is good but after thinking about it a bit, best to hold off until we have a need in jnet proper.
I think we need this now? Or did you end up adding it in another PR that we've since merged? Either way, status?
Oh, I don't think we need it yet. Sooner or later we might, so it's fine to let this one sit.