netrunner icon indicating copy to clipboard operation
netrunner copied to clipboard

fetch: Fetch translated card images in supported languages

Open csbisa opened this issue 1 year ago • 3 comments

jinteki.net has supported translated card images for a few years but no proper data import process existed, which this change attempts to rectify.

Initially, only Japanese images will be hosted on nrdbassets and supported-img-langs can be expanded once more languages are added.

To avoid 404ing on a whole lot of card images that will never exist, we restrict non-English image downloads to NSG-era cards. Note that we'll still get 404s on some data sets (alt arts, Salvaged Memories, System Core 2019). I can extend the filtering further if we care enough, but it might be best to live with 404s as we'll otherwise have to dance around newly released cards since translated cards aren't available for a few days to weeks after the English release.

csbisa avatar Jun 28 '23 00:06 csbisa

Note this shouldn't be merged until I give the all-clear -- mainly looking for any feedback in the meantime.

csbisa avatar Jun 28 '23 00:06 csbisa

Any updates on this?

NoahTheDuke avatar Nov 15 '23 15:11 NoahTheDuke

plural never got back to me about uploading the additional images to NRDB. Let me ping him again.

csbisa avatar Nov 17 '23 03:11 csbisa

Gonna close this for now. Holler if you get the info you need.

NoahTheDuke avatar May 01 '24 21:05 NoahTheDuke