netrunner icon indicating copy to clipboard operation
netrunner copied to clipboard

WIP re-implement disabling cards

Open NBKelly opened this issue 2 years ago • 2 comments

Doing this in a less eclectic fashion this time.

I'm picking one card (this time, rumor mill), changing it to a constant/floating effect, then working backwards to get things functional.

So far, the following changes have been made:

  • :on-rez effects require the card to not be disabled
  • Most of the effects that looked for a :disabled key now check :any-effect. The outliers at the moment are card-init, disable-card, and diffs
  • I still need to add a "gather all disabled cards and do changes" helper that goes in each checkpoint and fake-checkpoint

So far, the following cards have been changed:

  • Rumor Mill (the fake checkpoint can maybe go away, since it trashes anyway)

NBKelly avatar Nov 28 '22 04:11 NBKelly

A few more minutes of work here.

  • Recurring credits now refill when 'end-phase-12' is called. This is in line with the CR, and means we don't need to register an event on each individual recurring credits card. Additionally, it checks that the card is not disabled (via any-effect) as well.

This is basically one of the stepping stones to having disabled work. A few dozen more and we'll be there.

NBKelly avatar Dec 04 '22 09:12 NBKelly

Would love to see this worked on more.

NoahTheDuke avatar Nov 15 '23 15:11 NoahTheDuke

This has been done in #7400!

NoahTheDuke avatar May 01 '24 21:05 NoahTheDuke