netrunner icon indicating copy to clipboard operation
netrunner copied to clipboard

Clean up all of the 'TODO' statements in code

Open NBKelly opened this issue 2 years ago • 1 comments

There's a few of these that have accumulated over the years

  • [ ] new-game-button in 'src/cljs/nr/lobby.cljs' - "rewrite this check"
  • [ ] load-replay-button in 'src/cljs/nr/lobby.cljs' - "rewrite this check"
  • [ ] game-lobby in 'src/cljs/nr/lobby.cljs' - "make starting a game from the deckbuilder work again"
  • [ ] 'ws/event-msg-handler :angel-arena/run-update' - implement this feature
  • [ ] 'broadcast-to!insrc/clj/web/ws.clj` - multiple go blocks could compete, this might be a source of black screens sometimes. Update/fix this.
  • [ ] check-for-inactivity in src/clj/web/angel_arena.clj - maybe make this an option for all games (notify lobby of inactivity before you get booted)
  • [ ] ugly-counter-hack in src/clj/came/core/engine.clj - find a way to no longer need this hack
  • [ ] derez in src/clj/game/core/rezzing.clj - make this asynchronous (and maybe let it complete an eid too)
  • [ ] register-successful-run in src/clj/game/core/runs.cljs - We queue a pre-successful-run event in here, and it's implied we instead want these abilities (sneakdoor/omar) to instead prevent/replace the successful run
  • [x] card-str in src/clj/game/core/to_string.clj - add naming of scoring area of corp/runner
  • [ ] card-flag? in src/clj/game/core/flags.clj - Add a register for mutable state card flags, separate from this
  • [ ] prevent-draw/jack-out/prevent-current/lock-zone/release-zone in src/clj/game/core/flags.clj - look into migrating these to turn-flags and run-flags (or better yet, maybe they can be floating/constant effects?)
  • [ ] find-undefined-locals in src/clj/game/macros.clj - switch to requiring that passage if/when possible, instead of in-lining the function
  • [ ] Trade-In in src/clj/game/cards/events.clj - I'm not sure, but it's demanding attention
  • [x] Hunting Grounds in src/clj/game/cards/resources.clj - when suppression is fixed (has this happened yet?), should be (:ice context)
  • [ ] Jackpot! in src/clj/game/cards/resources.clj - this is async, but it's getting called in move (which is sync) - issue dated oct `20
  • [x] Political Operative in src/clj/game/cards/resources.clj - convert the continue-ability into a cost (also the label says "trash an ice" ???)
  • [ ] Bankroll in src/clj/game/cards/programs.clj - Dirty hack for interacting with Jak Sinclair ???

If you fix any of these, then link it to this issue.

NBKelly avatar Nov 27 '22 03:11 NBKelly