mtgjson icon indicating copy to clipboard operation
mtgjson copied to clipboard

ADD AllPricesToday as a smaller alternative

Open ZeldaZach opened this issue 2 years ago • 3 comments

  • Gives support so MTGGraphQL can pull prices in
  • Fix #673

AllPricesToday.json.txt.zip

ZeldaZach avatar May 27 '22 21:05 ZeldaZach

couple of comments, looking at the output file provided

                    "foil": {},

I think it'd be better to drop empty prices structs

  1. how are etched cards marked?
  2. we should normalize the finish names with upstream nonfoil and foil IMO
  3. the currency field does not belong to the price structure - if it's not for meta it should have a separate body at the same level of data
  4. make sure memory does not grow too much during execution
  5. what's the point of keeping the date?

kodawah avatar Jun 02 '22 14:06 kodawah

The original idea was to create a "smaller" version of the already existing file. While I agree there are some design choices that can be improved upon, I'd prefer to hold them off until we do a complete overhaul of the prices struct (Maybe we build sub-versions to keep compatibility?)

This would allow people to drag/drop in the AllPricesToday file as a replacement and get the data they need @kodabb

ZeldaZach avatar Jun 02 '22 14:06 ZeldaZach

This would allow people to drag/drop in the AllPricesToday file as a replacement and get the data they need

i don't think creating a future technical debt is a good idea

kodawah avatar Jun 02 '22 14:06 kodawah

We decided against this idea, and found an alternative. Still want to plan the ideas for a smaller file to distribute.

ZeldaZach avatar Jan 04 '23 03:01 ZeldaZach