mtgjson
mtgjson copied to clipboard
ADD AllPricesToday as a smaller alternative
couple of comments, looking at the output file provided
"foil": {},
I think it'd be better to drop empty prices structs
- how are etched cards marked?
- we should normalize the finish names with upstream
nonfoil
andfoil
IMO - the
currency
field does not belong to the price structure - if it's not formeta
it should have a separate body at the same level ofdata
- make sure memory does not grow too much during execution
- what's the point of keeping the date?
The original idea was to create a "smaller" version of the already existing file. While I agree there are some design choices that can be improved upon, I'd prefer to hold them off until we do a complete overhaul of the prices struct (Maybe we build sub-versions to keep compatibility?)
This would allow people to drag/drop in the AllPricesToday file as a replacement and get the data they need @kodabb
This would allow people to drag/drop in the AllPricesToday file as a replacement and get the data they need
i don't think creating a future technical debt is a good idea
We decided against this idea, and found an alternative. Still want to plan the ideas for a smaller file to distribute.